add Stdlib::Filesource#841
Conversation
merge upstream
merge upstream
b4ldr
force-pushed
the
type_filesource
branch
2 times, most recently
from
d9a9990 to
af8d73f
Compare
b4ldr
force-pushed
the
type_filesource
branch
from
af8d73f to
cb97581
Compare
|
rebased and updated to use new type testing as per #856 |
b4ldr
force-pushed
the
type_filesource
branch
from
cb97581 to
b45edf0
Compare
|
As per #856, you don't need the test::* manifest anymore, so it can be safely deleted from PR. |
b4ldr
force-pushed
the
type_filesource
branch
from
b45edf0 to
27bcc07
Compare
|
thanks @pegasd i missed that one, updated now |
| http://runningoutofideas.gov | ||
| file:///hello/bla | ||
| file:///foo/bar.log | ||
| puppet:///modules/foo/bar.log |
There was a problem hiding this comment.
You should also test puppet://someserver/modules/foo/bar.log
There was a problem hiding this comment.
@binford2k thanks for the pointer i didn't see that varient in the docs. Have updeated the type pattern and spec tests
b4ldr
force-pushed
the
type_filesource
branch
from
27bcc07 to
f852ba3
Compare
|
@binford2k Are you happy that the changes you requested have been made? |
| '\\Users/hc/wksp/stdlib', | ||
| 'C:noslashes', | ||
| '\\var\\tmp', | ||
| 'puppet:///foo/bar.log', |
There was a problem hiding this comment.
@binford2k This is actually valid though? https://puppet.com/docs/puppet/5.5/file_serving.html#whats-a-mount-point-in-a-puppet-uri
We're using this type in puppet-zabbix and a user has complained the regex is rejecting valid puppet fileserver mount points. voxpupuli/puppet-zabbix#580
There was a problem hiding this comment.
Yes, that should be valid.
6 participants
No description provided.