Revert "Allow pick() to work with strict variables"#927
Merged
david22swan merged 1 commit intopuppetlabs:masterfrom Jun 22, 2018
Merged
Revert "Allow pick() to work with strict variables"#927david22swan merged 1 commit intopuppetlabs:masterfrom
david22swan merged 1 commit intopuppetlabs:masterfrom
Conversation
This reverts commit 2a493ad. This change was not backwards compatible. If a user was using pick with a string that include a $, it would be evaluated and could throw an error. See https://bugs.launchpad.net/tripleo/+bug/1778201
Contributor
Author
|
@hlindberg @david22swan @binford2k please review |
apevec
pushed a commit
to redhat-openstack/rdoinfo
that referenced
this pull request
Jun 22, 2018
This reverts commit fd9748c. puppetlabs/puppetlabs-stdlib#927 was merged upstream to revert the issue. Change-Id: I2fc85cee2b3e94996b46ba25564d34d5a2969484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2a493ad.
This change was not backwards compatible. If a user was using pick with
a string that include a $, it would be evaluated and could throw an
error.
See https://bugs.launchpad.net/tripleo/+bug/1778201