Make any2array return empty array on empty string#930
Merged
david22swan merged 1 commit intopuppetlabs:masterfrom Jun 27, 2018
Merged
Make any2array return empty array on empty string#930david22swan merged 1 commit intopuppetlabs:masterfrom
david22swan merged 1 commit intopuppetlabs:masterfrom
Conversation
any2array currently returns an array containing the empty string, when
given the empty string.
Example:
```
any2array('').each |$e| {
notice('I\'m not empty!')
}
```
This is counter intuitive, as Puppet considers the empty string as
Strings nil value, for which the equivalent Array is the empty array.
This especially apparent when doing a lookup in a map with a non
existing key.
Example:
```
$config = {}
any2array($config['test']).each |$e| {
notice('I\'m not empty!')
}
```
Both these cases print the string "I'm not empty", this PR fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
any2array currently returns an array containing the empty string, when
given the empty string.
Example:
This is counter intuitive, as Puppet considers the empty string as
Strings nil value, for which the equivalent Array is the empty array.
This especially apparent when doing a lookup in a map with a non
existing key.
Example:
Both these cases print the string
I'm not empty, this PR fixes that.