Skip to content

fix(repl): avoid cloning the global name map on feed#254

Open
tristanang wants to merge 3 commits intopydantic:mainfrom
tristanang:t3code/fix-monty-issue-249
Open

fix(repl): avoid cloning the global name map on feed#254
tristanang wants to merge 3 commits intopydantic:mainfrom
tristanang:t3code/fix-monty-issue-249

Conversation

@tristanang
Copy link
Copy Markdown

@tristanang tristanang commented Mar 8, 2026

Summary

  • mutate the REPL global name map in place during incremental prepare instead of cloning it for each feed/start
  • remove the old incremental name-map commit path and keep only intern/function metadata commits after execution
  • add regression tests covering compile-time failures that reserve a global slot before erroring

Testing

  • make install-py
  • make format-rs
  • make lint-rs
  • cargo test -p monty --test repl

fixes #249

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 33.60656% with 81 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/monty/src/repl.rs 35.22% 27 Missing and 30 partials ⚠️
crates/monty/src/prepare.rs 29.41% 20 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 8, 2026

Merging this PR will not alter performance

✅ 13 untouched benchmarks


Comparing tristanang:t3code/fix-monty-issue-249 (1632a02) with main (e59c8fa)

Open in CodSpeed

@tristanang tristanang force-pushed the t3code/fix-monty-issue-249 branch from a68c8cf to 3c4d4e9 Compare March 10, 2026 18:47
@tristanang tristanang marked this pull request as ready for review March 10, 2026 22:11
@tristanang tristanang marked this pull request as draft March 10, 2026 22:20
@tristanang tristanang marked this pull request as draft March 10, 2026 22:20
@tristanang tristanang marked this pull request as ready for review March 10, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REPL: avoid cloning global_name_map on every feed

1 participant