Vendor deprecate_kwarg to fix pandas 3.0 ImportError (#1005)#1013
Open
Jaypatel1511 wants to merge 1 commit into
Open
Vendor deprecate_kwarg to fix pandas 3.0 ImportError (#1005)#1013Jaypatel1511 wants to merge 1 commit into
Jaypatel1511 wants to merge 1 commit into
Conversation
…ecorators (pydata#1005) pandas-datareader imported deprecate_kwarg from pandas.util._decorators, a private internal API being removed in pandas 3.0. This caused an ImportError on pandas >= 3.0. Fix: vendor the implementation directly in pandas_datareader.compat and update data.py to import from there instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1005 —
pandas-datareaderimporteddeprecate_kwargfrompandas.util._decorators, a private internal API that is being removed in pandas 3.0. This causes anImportErroron pandas >= 3.0, breaking every import of the library.Root cause
Fix
Vendor the
deprecate_kwargimplementation directly intopandas_datareader.compat(matching the behaviour of the pandas original), and updatedata.pyto import from there:The vendored implementation in
compat/__init__.pyis a faithful port of the pandas original, supporting:mappingdict or callable for value translationTypeErrorwhen both old and new kwargs are passed simultaneouslynew_arg_name=Nonefor pure deprecation warningsTest plan
tests/test_deprecate_kwarg.pycovering all decorator behavioursdata.pyno longer referencespandas.util._decorators