Skip to content

Add regression test for issue #5408#5795

Merged
DanielNoord merged 4 commits intopylint-dev:mainfrom
DanielNoord:recursion
Mar 12, 2022
Merged

Add regression test for issue #5408#5795
DanielNoord merged 4 commits intopylint-dev:mainfrom
DanielNoord:recursion

Conversation

@DanielNoord
Copy link
Copy Markdown
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
🐛 Bug fix

Description

Depends on pylint-dev/astroid#1392
Closes #5408.

@DanielNoord DanielNoord added Crash 💥 A bug that makes pylint crash Needs astroid update Needs an astroid update (probably a release too) before being mergable labels Feb 11, 2022
@DanielNoord DanielNoord added this to the 2.13.0 milestone Feb 11, 2022
Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jacobtylerwalls
Copy link
Copy Markdown
Member

(Don't forget to remove the diofant submodule.)

Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(diofant need to be removed)

@DanielNoord
Copy link
Copy Markdown
Collaborator Author

Pff, VS Code is really bad in showing whenever you add a submodule accidentally (or I am just bad at noticing). Changed! Thanks @jacobtylerwalls

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1973442042

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.025%

Totals Coverage Status
Change from base Build 1973318874: 0.0%
Covered Lines: 15029
Relevant Lines: 15984

💛 - Coveralls

@DanielNoord DanielNoord merged commit 72193ab into pylint-dev:main Mar 12, 2022
@DanielNoord DanielNoord deleted the recursion branch March 12, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Crash 💥 A bug that makes pylint crash Needs astroid update Needs an astroid update (probably a release too) before being mergable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pylint endless recursion with short example using setuptools.build_meta import

4 participants