Add examples for await-outside-async and fix activation of message#6016
Merged
DanielNoord merged 3 commits intopylint-dev:mainfrom Mar 28, 2022
Merged
Add examples for await-outside-async and fix activation of message#6016DanielNoord merged 3 commits intopylint-dev:mainfrom
await-outside-async and fix activation of message#6016DanielNoord merged 3 commits intopylint-dev:mainfrom
Conversation
DanielNoord
approved these changes
Mar 28, 2022
Collaborator
DanielNoord
left a comment
There was a problem hiding this comment.
Thanks @DudeNr33!
Nice to see how this process is finding some hard to spot issue as well. I have also found some missing check_messages through this process 😄
4 tasks
Pull Request Test Coverage Report for Build 2052735367
💛 - Coveralls |
Member
Sounds like something that is supposed to take some time to find out 😄 Thanks for the debug ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
This adds examples and link to the relevant PEP for
await-outside-async.The new test case for checking the message docs actually found a bug (which cost me more time to find than I'd be willing to admit 😀 ):
Because the relevant
visit_awaitmethod was implemented in the wrong checker class (there are two in the module), it was not possible to disable all messages and then just enableawait-outside-asyncagain.As both the impact and the fix of this are so minor I decided to directly fix this in this PR and only add a ChangeLog entry, without separate issue or whatsnew entry.
Let me know if you'd rather want to split this into two PRs.
Ref: #5953