Skip to content

Added literal-comparison message example#6159

Merged
Pierre-Sassoulas merged 3 commits intopylint-dev:mainfrom
matusvalo:literal-comparison
Apr 3, 2022
Merged

Added literal-comparison message example#6159
Pierre-Sassoulas merged 3 commits intopylint-dev:mainfrom
matusvalo:literal-comparison

Conversation

@matusvalo
Copy link
Copy Markdown
Collaborator

Co-authored-by: Vladyslav Krylasov vladyslav.krylasov@gmail.com

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

Related #5953

Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a function is better sometime so we have an "unknown" value and meaningful code.

Comment thread doc/data/messages/l/literal-comparison/bad.py Outdated
Comment thread doc/data/messages/l/literal-comparison/good.py Outdated
@Pierre-Sassoulas
Copy link
Copy Markdown
Member

We should probably link to : https://docs.python.org/3/library/stdtypes.html#comparisons

@matusvalo
Copy link
Copy Markdown
Collaborator Author

We should probably link to : https://docs.python.org/3/library/stdtypes.html#comparisons

done

@Pierre-Sassoulas Pierre-Sassoulas merged commit 6718502 into pylint-dev:main Apr 3, 2022
@matusvalo matusvalo deleted the literal-comparison branch April 3, 2022 19:09
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants