Skip to content

Add documentation examples of consider-using-f-string #6460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pierre-Sassoulas merged 4 commits into from
Apr 27, 2022
Merged

Add documentation examples of consider-using-f-string #6460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9767392
Add documentation examples of consider-using-f-string
timmartin Apr 25, 2022
f3a98a5
Add some extra examples, and a details.rst to explain it
timmartin Apr 26, 2022
68618c3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 26, 2022
958df0c
Update doc/data/messages/c/consider-using-f-string/details.rst
Pierre-Sassoulas Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/data/messages/c/consider-using-f-string/bad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
menu = ('eggs', 'spam')
Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
menu = ('eggs', 'spam')
from string import Template
menu = ('eggs', 'spam', 42.42)


order = "%s and %s" % menu # [consider-using-f-string]

new_order = "{1} and {0}".format(menu[0], menu[1]) # [consider-using-f-string]
Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
order = "%s and %s" % menu # [consider-using-f-string]
new_order = "{1} and {0}".format(menu[0], menu[1]) # [consider-using-f-string]
old_order = "%s and %s: %.2f ¤" % menu # [consider-using-f-string]
beginner_order = menu[0] + "and " + menu[1] + ": " + str(menu[2]) + " ¤"
joined_order = "and ".join(menu)
format_order = "{} and {}: {:0.2f} ¤".format(menu[0], menu[1], menu[2]) # [consider-using-f-string]
named_format_order = "{eggs} and {spam}: {price:0.2f} ¤".format(eggs=menu[0], spam=menu[1], price=menu[2]) # [consider-using-f-string]
template_order = Template('$eggs and $spam: $price ¤').substitute(eggs=menu[0], spam=menu[1], price=menu[2])

Copy link
Copy Markdown
Contributor Author

@timmartin timmartin Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, thanks for introducing me to the ¤ sign!

5 changes: 5 additions & 0 deletions doc/data/messages/c/consider-using-f-string/good.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
menu = ('eggs', 'spam')

order = f"{menu[0]} and {menu[1]}"

new_order = f"{menu[1]} and {menu[0]}"
Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
order = f"{menu[0]} and {menu[1]}"
new_order = f"{menu[1]} and {menu[0]}"
f_string_order = f"{menu[0]} and {menu[1]}: {menu[2]:0.2f} ¤"

⚡