Skip to content

Better assert message for documentation tests #6575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pierre-Sassoulas merged 2 commits into from
May 11, 2022
Merged

Better assert message for documentation tests #6575

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
658bfa2
Better assert message for documentation tests
Pierre-Sassoulas May 11, 2022
ed45c5f
Update doc/test_messages_documentation.py
Pierre-Sassoulas May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions doc/test_messages_documentation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,11 @@ def _runTest(self) -> None:
expected_messages = self._get_expected()
actual_messages = self._get_actual()
if self.is_good_test_file():
assert actual_messages.total() == 0 # type: ignore[attr-defined]
msg = "There should be no warning raised for 'goob.py'"
Comment thread
Pierre-Sassoulas marked this conversation as resolved.
Outdated
assert actual_messages.total() == 0, msg # type: ignore[attr-defined]
if self.is_bad_test_file():
assert actual_messages.total() > 0 # type: ignore[attr-defined]
msg = "There should be at least one warning raised for 'bad.py'"
assert actual_messages.total() > 0, msg # type: ignore[attr-defined]
assert expected_messages == actual_messages


Expand Down
⚡