Add __init__.py files to message test dirs#8772
Merged
Pierre-Sassoulas merged 1 commit intomainfrom Jun 13, 2023
Merged
Conversation
jacobtylerwalls
added
tests
Skip news 🔇
jacobtylerwalls
changed the title
__init__ files to message test dirs__init__.py files to message test dirs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8772 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 173 173
Lines 18437 18437
=======================================
Hits 17669 17669
Misses 768 768 |
Pierre-Sassoulas
approved these changes
Jun 13, 2023
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Nice catch, I was working in it with less success 😄
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 13, 2023
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #8762
Other doc checks that have multiple files under
good/orbad/have an__init__.pyfile. The specific way tox was launching the tests was causing astroid to expect an__init__.pyfile, and these two didn't have them.