feature: allow testing cp38-macosx_arm64 wheel#1283
Conversation
Per discussion in pypa#1169, the default installer used for cp38 is an Intel installer. It makes sense to skip testing arm64 wheels in this case. However, if the user choose to manually install the universal2 CPython version, then, tests shall be run on arm64. This allows users that either target 11.0+ on intel, universal2 or only build for arm64 to get the arm64 wheel tested on AppleSilicon.
for more information, see https://pre-commit.ci
|
I've got an idea here. I'll try to get to it in a day or so. |
|
Thanks @mayeut. This provides a workaround for users with compiled dependencies that need native arm64 builds. I'm curious what @henryiii has in mind also...
Yeah, maybe. I'll save a full review until I've seen the approach henryiii has in mind. We could also limit the cp38-arm64 test job to test_0_basic, test_testing, test_macos_archs to save some CI time. |
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
Playing with it a bit, I think we'll need to discuss some more, and I don't think this gets in the way & it might help.
joerick
left a comment
joerick
left a comment
There was a problem hiding this comment.
Agreed. This is a good step, but maybe we'll do more here too.
|
Thank you @mayeut! |
3 participants
Per discussion in #1169, the default installer used for cp38 is an Intel installer. It makes sense to skip testing arm64 wheels in this case.
However, if the user choose to manually install the universal2 CPython version (c.f. #1278 (comment)), then, tests shall be run on arm64.
This allows users that either target 11.0+ on intel, universal2 or only build for arm64 to get the arm64 wheel tested on AppleSilicon.
I'm not a fan of the way I added the test here but there's a test. Maybe the test suite should be updated to run fully with both installers ?