Removed unused verification of supported commands#101
Merged
sigmavirus24 merged 4 commits intopypa:masterfrom Apr 14, 2015
Merged
Removed unused verification of supported commands#101sigmavirus24 merged 4 commits intopypa:masterfrom
sigmavirus24 merged 4 commits intopypa:masterfrom
Conversation
Member
|
LGTM. Thanks @rodcloutier |
sigmavirus24
added a commit
that referenced
this pull request
Apr 14, 2015
Removed unused verification of supported commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the cli.py module coverage was not reported as complete the but the tests seemed to be fine, testing all cases. I noticed that a verification of supported commands was hit by the tests hence the tests succeeding but the coverage not full.
I removed the verification code since the command option uses a choice which will report any unsupported commands.
Test run before
Test run after