Fix #116

[mhils]

getpass.getpass only accepts str as its first parameter on Windows.

Closes #116

Python 2: getpass.getpass only accepts str as its first parameter on Windows.
Python 3: getpass.getpass only accepts unicode as its first parameter on Windows.

[sigmavirus24]

If getpass only accepts str then this will break users running Twine on Python 3. Further, passing bytes doesn't make sense. Did you mean to do b'...'.decode('utf8')? That will do the right thing on all versions of Python

[mhils]

As it seems, you can only pass bytes on Python 2 - on Python 3, it's the other way around:

> python
Python 2.7.10 (default, May 23 2015, 09:40:32) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import getpass

>>> getpass.getpass(u"test")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Python27\lib\getpass.py", line 95, in win_getpass
    msvcrt.putch(c)
TypeError: must be char, not unicode

>>> getpass.getpass(b"test")
test
''

> python3
Python 3.4.1 (v3.4.1:c0e311e010fc, May 18 2014, 10:38:22) [MSC v.1600 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import getpass

>>> getpass.getpass(u"test")
test
''

>>> getpass.getpass(b"test")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Python34\lib\getpass.py", line 104, in win_getpass
    msvcrt.putwch(c)
TypeError: must be a unicode character, not int

How do you work around py2/3 issues usually here?

[sigmavirus24]

So I would write a function that does the proper checks for windows and then version in twine/utils.py such that it does something like

def password_prompt(prompt_text):  # Always expects unicode for our own sanity
    prompt = prompt_text
    if 'nt' in platform_info:
        if sys.version_info < (3, 0):
            prompt = prompt_text.encode('utf8')
    return functools.partial(getpass.getpass, prompt=prompt)

get_password = functools.partial(
    # ...
    prompt_strategy=password_prompt("Enter your password:"),
)

[mhils]

I just updated the PR - sorry that it took so long. 😃

[mhils]

Travis is happy now as well.

[sigmavirus24]

Sorry I missed that you had updated this @mhils! Thanks for fixing this! 🍰