Upload refactor#122
Merged
sigmavirus24 merged 6 commits intopypa:masterfrom Sep 13, 2015
Merged
Conversation
Update them to point at the new refactored code
The tests were failing because we were passing a list instead of a tuple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This properly splits out the logic between repository, package, and command wrappers.
This also adds a
registercommand which has been often requested to show off the power of the refactor.Currently the tests are failing but I can't determine what the difference is between pretend calls via the pytest output. Here's hoping they don't fail here.