Skip to content

Fix: pyRevitExtensionParser.dll and pyRevitAssemblyBuilder.dll unsigned in v6.1.0#3142

Closed
Copilot wants to merge 1 commit intodevelopfrom
copilot/check-dll-signing-status
Closed

Fix: pyRevitExtensionParser.dll and pyRevitAssemblyBuilder.dll unsigned in v6.1.0#3142
Copilot wants to merge 1 commit intodevelopfrom
copilot/check-dll-signing-status

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 27, 2026

In v6.1.0, pyRevitExtensionParser.dll and pyRevitAssemblyBuilder.dll shipped unsigned, causing SentinelOne and similar EDR tools to quarantine them. The culprit was a stray space in the files-folder-filter parameter of the Azure Trusted Signing step.

Root Cause

# v6.1.0 — space before pyRevit*.dll causes it to be parsed as " pyRevit*.dll" (no match)
files-folder-filter: pyrevit*.exe,pyrevit*.dll, pyRevit*.dll

# Fixed
files-folder-filter: pyrevit*.exe,pyrevit*.dll,pyRevit*.dll

azure/trusted-signing-action@v1.0.0 does not trim whitespace from comma-separated patterns. The leading space meant nothing prefixed with pyRevit (capital R) was ever matched, silently skipping all 8 DLL copies across the four engine directories (netfx/IPY2712PR, netfx/IPY342, netcore/IPY2712PR, netcore/IPY342).

Impact

All pyRevit-prefixed DLLs were unaffected by the signing pass in v6.1.0, including pyRevitLoader.dll, pyRevitRunner.dll, pyRevitLabs.*.dll, and the two reported DLLs. Only lowercase-pyrevit* files (pyrevit.dll, pyrevit-doctor.dll, pyrevit.exe) were signed.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@devloai
Copy link
Copy Markdown
Contributor

devloai bot commented Feb 27, 2026

Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

Copilot AI changed the title [WIP] Investigate signing status of DLLs in version 6.1.0 Fix: pyRevitExtensionParser.dll and pyRevitAssemblyBuilder.dll unsigned in v6.1.0 Feb 27, 2026
@jmcouffin jmcouffin closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants