Skip to content

Fix @takes_callable_and_args TypeVar binding bug #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oremanj merged 1 commit into from
Mar 28, 2023
Merged

Fix @takes_callable_and_args TypeVar binding bug #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions trio_typing/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,10 +463,11 @@ def start_soon(
+ ([None] * len(type_var_types))
+ callable_ty.arg_names[callable_args_idx + 1 :]
),
variables=(
list(callable_ty.variables)
+ cast(List[TypeVarLikeType], type_var_types)
),
# Note that we do *not* append `type_var_types` to
# `callable_ty.variables`. Even though `*type_var_types` are in our new
# `callable_ty`'s argument types, they are *not* type variables that get
# bound when our new `callable_ty` gets called. They get bound when the
# `expanded_fn` that references our new `callable_ty` gets called.
Comment on lines -466 to +470
Copy link
Copy Markdown
Member

@belm0 belm0 Feb 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this fix, in turn, cause errors from older mypy?

)
expanded_fns.append(
fn_type.copy_modified(
Expand Down
⚡