[3.13] gh-145548: Don't use VMADDR_CID_LOCAL from socket#145735
Merged
encukou merged 1 commit intopython:3.13from Mar 10, 2026
Merged
[3.13] gh-145548: Don't use VMADDR_CID_LOCAL from socket#145735encukou merged 1 commit intopython:3.13from
socket#145735encukou merged 1 commit intopython:3.13from
Conversation
VMADDR_CID_LOCAL was added to `socekt` in 3.14. The test needs a local constant in setUp(), as in clientSetUp().
Member
Author
|
!buildbot Fedora.Stable$ |
|
The regex 'Fedora.Stable$' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
Member
Author
|
!buildbot Fedora.Stable |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 9a6de87 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145735%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner
approved these changes
Mar 10, 2026
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I tested manually on Fedora Stable x86-64: the change works as expected. The test is skipped:
testStream (test.test_socket.ThreadedVSOCKSocketStreamTest.testStream) ... skipped "bind() failed with OSError(99, 'Cannot assign requested address')"
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Mar 11, 2026
…honGH-145735) VMADDR_CID_LOCAL was added to `socekt` in 3.14. The test needs a local constant in setUp(), as in clientSetUp().
Yhg1s
pushed a commit
that referenced
this pull request
Apr 15, 2026
…) (#145809) * [3.12] gh-145548: Use VMADDR_CID_LOCAL in VSOCK socket tests (GH-145589) (GH-145594) Prefer VMADDR_CID_LOCAL instead of VMADDR_CID_ANY for bind() in the server. Skip the test if bind() fails with EADDRNOTAVAIL. Log vsock CID in test.pythoninfo. (cherry picked from commit 6c8c72f) (cherry picked from commit 16dbbe5) * [3.13] gh-145548: Don't use VMADDR_CID_LOCAL from `socket` (GH-145735) VMADDR_CID_LOCAL was added to `socekt` in 3.14. The test needs a local constant in setUp(), as in clientSetUp(). Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Apr 15, 2026
…ythonGH-145589) (pythonGH-145809) * [3.12] pythongh-145548: Use VMADDR_CID_LOCAL in VSOCK socket tests (pythonGH-145589) (pythonGH-145594) Prefer VMADDR_CID_LOCAL instead of VMADDR_CID_ANY for bind() in the server. Skip the test if bind() fails with EADDRNOTAVAIL. Log vsock CID in test.pythoninfo. (cherry picked from commit 6c8c72f) (cherry picked from commit 16dbbe5) * [3.13] pythongh-145548: Don't use VMADDR_CID_LOCAL from `socket` (pythonGH-145735) VMADDR_CID_LOCAL was added to `socekt` in 3.14. The test needs a local constant in setUp(), as in clientSetUp(). (cherry picked from commit e378eda) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Apr 15, 2026
…ythonGH-145589) (pythonGH-145809) * [3.12] pythongh-145548: Use VMADDR_CID_LOCAL in VSOCK socket tests (pythonGH-145589) (pythonGH-145594) Prefer VMADDR_CID_LOCAL instead of VMADDR_CID_ANY for bind() in the server. Skip the test if bind() fails with EADDRNOTAVAIL. Log vsock CID in test.pythoninfo. (cherry picked from commit 6c8c72f) (cherry picked from commit 16dbbe5) * [3.13] pythongh-145548: Don't use VMADDR_CID_LOCAL from `socket` (pythonGH-145735) VMADDR_CID_LOCAL was added to `socekt` in 3.14. The test needs a local constant in setUp(), as in clientSetUp(). (cherry picked from commit e378eda) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VMADDR_CID_LOCAL was added to
socketin 3.14.For 3.13, the test needs a local constant in setUp(), as in clientSetUp().