bpo-30592: Fixed error messages for some builtins.#1996
bpo-30592: Fixed error messages for some builtins.#1996serhiy-storchaka merged 1 commit intopython:masterfrom
Conversation
Error messages when pass keyword arguments to some builtins that don't support keyword arguments contained double parenthesis: "()()". The regression was intriduced by bpo-30534.
SylvainDe
left a comment
There was a problem hiding this comment.
Looks good to me!
Do you reckon I'd make sense to have a unit test for a least one of these functions ?
Also, should we improve the _PyArg_NoKeywords documentation to mention that the provided function name is supposed to not have the parenthesis?
|
This PR fixed 23 functions and methods. Tests for just one function wouldn't cover other cases, and adding 23 tests looks excessively. But adding tests for general cases which cover a lot of function is welcome.
There is no documentation for |
Error messages when pass keyword arguments to some builtins that
don't support keyword arguments contained double parenthesis: "()()".
The regression was intriduced by bpo-30534.