bpo-42643: Add support for HTTP range requests#24228
bpo-42643: Add support for HTTP range requests#24228DavidBord wants to merge 2 commits intopython:mainfrom
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
|
@DavidBord Thanks! I think built-in range support is going to be helpful |
|
It’s needed to resume downloads and this may significantly reduce load in some cases. That’s why even minimal busybox httpd has a support of Range requests |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
|
This is a most welcome update. Thank you @DavidBord |
|
Personally I think it's fundamental to support Others I think are OK. I'm using a modified version of this patch in my program https://github.com/imba-tjd/qrsend. I will share info when I found defects. |
| shutil.copyfileobj(source, outputfile) | ||
| if start_byte is not None and end_byte is not None: | ||
| source.seek(start_byte) | ||
| outputfile.write(source.read(end_byte)) |
There was a problem hiding this comment.
Fatal error. When you use 2-5, the start_byte is 2 and end_byte is 5. Then you read(5).
The correct behavior is read(4), which is end_byte-start_byte+1. Though I won't suggest whether putting +1 here or previous place.
More importantly, read() will load all data into memory in a row before start writing. This has serious performance issue when resuming large file. I tried source.truncate() but it turns out an io.UnsupportedOperation.
Besides Content-Length needs changing too. So that new testing is recommended to be added, too.
github-actions
bot
removed
the
stale
|
Is there a way to help reviewing this PR? I'd like to help. |
There was another PR which was detailed discussed. However it seems to be deleted. Maybe it will be recoverd. This PR is poorly implemented and can be closed IMO. |
|
You can use |
11 participants
https://bugs.python.org/issue42643