[mypyc] Emit messages regardless if there's no errors#10940
Closed
ichard26 wants to merge 2 commits intopython:masterfrom
Closed
[mypyc] Emit messages regardless if there's no errors#10940ichard26 wants to merge 2 commits intopython:masterfrom
ichard26 wants to merge 2 commits intopython:masterfrom
Conversation
Member
|
Looks like this is breaking mypy's build of itself, could you take a look? |
Collaborator
Author
|
So me having zero foreshadowing abilities forgot that warnings would also cause the build to exit with a non-zero return code 🙃. Mypyc now exits with 1 if errors occurred. Fixed one of the more concerning warnings from mypyc too. |
Collaborator
Author
|
Gosh, the test infra doesn't include the messages output unless the returncode was non-zero (or the test case was suffixed with |
While warnings aren't great, given that mypyc is in alpha and has a limited support surface currently exiting on warnings is a bit much. Also fixed this warning: mypy/semanal.py:228: warning: Unsupported default attribute value
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
Author
|
Superseded by #14451. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related: mypyc/mypyc#873 (comment)
For example the warning for "treating generator comprehension as list"
doesn't get printed unless there were errors too. This was due to
the fact mypyc/build.py was only checking errors.num_errors totally
ignoring the possitibilties of warnings or notes happening alone.
Test Plan