Fix crashes with unpacking SyntaxError#11499
Merged
hauntsaninja merged 4 commits intopython:masterfrom Nov 15, 2022
Merged
Conversation
In general, mypy doesn't promise to be able to check the remainder of your code in the presence of syntax errors, so just make this a blocking error. Fixes python#9137 Fixes python#3825 (most of the reports in this issue were fixed by python#8827)
This comment has been minimized.
This comment has been minimized.
Collaborator
|
@hauntsaninja Is it okay if a new mypy contributor finishes this PR as an onboarding task? |
Collaborator
Author
|
Yeah of course! Although a blocking error on aiohttp is not an acceptable regression. |
Member
|
@JukkaL What is the situation with this? It has been almost three months without news, maybe it would be better let @hauntsaninja actually finish this? I would prefer to get this into 1.0 |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
Author
|
Cool, got this working. Assuming we're okay with potential new blocking errors this could be merged |
ilevkivskyi
approved these changes
Nov 14, 2022
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
FWIW syntax errors should be blocking, so I think this is good. Of course we need to be sure we marked all possible locations as valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, mypy doesn't promise to be able to check the remainder of
your code in the presence of syntax errors, so just make this a blocking
error.
Fixes #9137
Fixes #3825 (most of the reports in this issue were fixed by #8827)