Skip to content

Prevent warnings from causing dmypy to fail#14102

Merged
ilevkivskyi merged 2 commits intopython:masterfrom
neob91-close:fix-dmypy-exit-code
Nov 15, 2022
Merged

Prevent warnings from causing dmypy to fail#14102
ilevkivskyi merged 2 commits intopython:masterfrom
neob91-close:fix-dmypy-exit-code

Conversation

@neob91-close
Copy link
Copy Markdown
Contributor

Fixes: #14101

This prevents non-error messages (e.g. warnings) from causing dmypy to return exit code 1.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Copy Markdown
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@ilevkivskyi ilevkivskyi merged commit e01359d into python:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unchecked annotation note causes dmypy to exit with code 1 on a successful run

2 participants