Skip to content

Don't read scripts without extensions as modules in namespace mode #14335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 3 commits into from
Jan 10, 2023
+5 −1
Merged

Don't read scripts without extensions as modules in namespace mode #14335

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67a26ba
don't read scripts without extensions as modules
getim Dec 20, 2022
2405b3a
add script-files that should not be picked up
getim Dec 21, 2022
4fe1154
Micro-optimise condition
hauntsaninja Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mypy/modulefinder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,11 @@ def _find_module(self, id: str, use_typeshed: bool) -> ModuleSearchResult:

# In namespace mode, register a potential namespace package
if self.options and self.options.namespace_packages:
if fscache.exists_case(base_path, dir_prefix) and not has_init:
if (
fscache.exists_case(base_path, dir_prefix)
and not fscache.isfile_case(base_path, dir_prefix)
and not has_init
Comment thread
hauntsaninja marked this conversation as resolved.
Outdated
):
near_misses.append((base_path, dir_prefix))

# No package, look for module.
Expand Down
Empty file added test-data/packages/modulefinder/nsx-pkg3/nsx/c/c
View file
Open in desktop
Empty file.
Empty file added test-data/packages/modulefinder/pkg1/a
View file
Open in desktop
Empty file.
⚡