Conversation
We can sometimes simplify an RType union, even if the mypy union couldn't be simplified. A typical example is `list[x] | list[y]` which can be simplified to just `list`. Previously this would generate a redundant union `union[list, list]`.
svalentin
approved these changes
Dec 28, 2022
JukkaL
added a commit
that referenced
this pull request
Dec 28, 2022
Fix crash related to unions in loops. The crash was introduced in #14363. Flatten nested unions before simplifying unions.
JukkaL
added a commit
that referenced
this pull request
Dec 29, 2022
Flatten nested unions before simplifying unions. Simplify item type unions in loops. This fixes a crash introduced in #14363.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can sometimes simplify a mypyc RType union, even if the mypy union couldn't be simplified. A typical example is
list[x] | list[y]which can be simplified to justlist. Previously this would generate a redundant unionunion[list, list].