Fix bug with in operator used with a union of Container and Iterable#14384
Merged
JukkaL merged 4 commits intopython:masterfrom Jan 30, 2023
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Jan 11, 2023
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good, just one nit.
| We allow `in` for a union of containers and iterables as long as at least one of them matches the | ||
| type of the left operand, as the operation will simply return False if the union's container/iterator | ||
| type doesn't match the left operand. | ||
| """ |
Collaborator
There was a problem hiding this comment.
Style nit: We use # comments also for block comments.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4954.
Modifies analysis of
incomparison expressions. Previously, mypy would check the right operand of aninexpression to see if it was a union ofContainers, and then if it was a union ofIterables, but would fail on unions of bothContainers andIterables.