[mypyc] Optimize int()/float()/complex() on native classes#14450
Merged
JukkaL merged 5 commits intopython:masterfrom Jan 18, 2023
Merged
Conversation
int() and float() calls on native classes can simply call the associated dunder if the RInstance defines it, no need to load the type and call it. bool() calls were already optimized merely a few days ago, but there wasn't an IRbuild test verifying this so I added one.
ichard26
force-pushed
the
optimize-native-class-conversion-to-int-and-float
branch
from
36a4d78 to
c094384
Compare
ichard26
commented
Jan 15, 2023
Collaborator
Author
|
Hmm, I just discovered the |
JukkaL
approved these changes
Jan 16, 2023
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks! Looks good. I'll keep this open for a while in case you will add support for __complex__.
This comment has been minimized.
This comment has been minimized.
JukkaL
reviewed
Jan 17, 2023
ichard26
changed the title
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
ichard26
deleted the
optimize-native-class-conversion-to-int-and-float
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
int() and float() calls on native classes can simply call the associated dunder if the RInstance defines it, no need to load the type and call it.
bool() calls were already optimized merely a few days ago, but there wasn't an IRbuild test verifying this so I added one.
Follow up to #14422. I saw the PR and it reminded me that I had this old patch laying around :)