Skip to content

Fix crash in await inside comprehension outside function#14486

Merged
JukkaL merged 1 commit intopython:masterfrom
ilevkivskyi:fix-await-crash
Jan 21, 2023
Merged

Fix crash in await inside comprehension outside function#14486
JukkaL merged 1 commit intopython:masterfrom
ilevkivskyi:fix-await-crash

Conversation

@ilevkivskyi
Copy link
Copy Markdown
Member

Fixes #14345

I also decided to make this error a blocker, since it is essentially a syntax error. (And also a similar error for yield is a blocker).

@AlexWaygood AlexWaygood added the topic-async async, await, asyncio label Jan 21, 2023
@github-actions
Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Copy Markdown
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JukkaL JukkaL merged commit eea917e into python:master Jan 21, 2023
@ilevkivskyi ilevkivskyi deleted the fix-await-crash branch January 21, 2023 14:42
JelleZijlstra pushed a commit that referenced this pull request Feb 28, 2023
Now users can disable the first kind of error, but not the second kind
(which is always a syntax error).

Refs #14486
Closes #14763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-async async, await, asyncio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect asynchronous comprehension cause an internal error

3 participants