Consistently use literal-required error code for TypedDicts#14621
Merged
ilevkivskyi merged 2 commits intopython:masterfrom Feb 7, 2023
Merged
Consistently use literal-required error code for TypedDicts#14621ilevkivskyi merged 2 commits intopython:masterfrom
ilevkivskyi merged 2 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Feb 7, 2023
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Based on the clean mypy_primer output, this doesn't seem to be a major backward compatibility issue.
| ------------------------------------------------------------ | ||
|
|
||
| There are some places where only a (string) literal value is expected for | ||
| the purposes of statis type checking, for example a ``TypedDict`` key, or |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #7178
This code is used for some TypedDict errors, but
miscwas used for others. I make it more consistent. Also this code looks undocumented, so I add some basic docs.