adjust inconsistent dataclasses plugin error messages#14637
Merged
JukkaL merged 1 commit intopython:masterfrom Feb 7, 2023
Merged
adjust inconsistent dataclasses plugin error messages#14637JukkaL merged 1 commit intopython:masterfrom
JukkaL merged 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes prompted by @JukkaL's comment on another review. Splitting this out from that PR since it's unrelated and the messages here have been around for a few years.
This commit specifically adds quotes around Python identifiers in two error messages, and points the error for
"eq" must be True if "order" is Truemore directly at the decorator that triggers the error message.