[mypyc] Use primitives for calls via type aliases#14784
Merged
Conversation
Previously type aliases were looked up from the globals dictionary, even if the target was a primitive type such as list. Now type aliases are treated the same as direct references to types in calls, since type aliases are assumed to be immutable. This speeds up the deltablue benchmark by about 4%.
jhance
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously type aliases were looked up from the globals dictionary, even if the target was a primitive type such as list. Now type aliases are treated the same as direct references to types in calls, since type aliases are assumed to be immutable.
This speeds up the deltablue benchmark by about 4%.