Fix attrs.evolve on bound TypeVar#15022
Merged
hauntsaninja merged 2 commits intopython:masterfrom Apr 12, 2023
Merged
Conversation
3a8b535 to
dfd155b
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
5088b60 to
a3364f1
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
approved these changes
Apr 12, 2023
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Looks great, thank you!
Contributor
Author
|
@hauntsaninja thinking about it, is there an existing facility I can use here, so that I could also support unions? Feels like checking |
Collaborator
|
Good question, if you can get something from mypy.checkmember to work for you that's probably the way to go |
Contributor
Author
|
That was my first thought, but checkmember is complex and probably ill-fitted for anything that's not true member access. I thought I'd need some kind of TypeVisitor that'll list the types, then iterate over the types and "union" the signatures, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error on the last line of this example:
Since
Tis bounded byA, we know it can be treated asA.