Skip to content

[out] version checks must be against min version or higher #15430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 2 commits into from
Jun 13, 2023
Merged

[out] version checks must be against min version or higher #15430

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16a4e57
[out] version checks must be against min version or higher
ikonst Jun 13, 2023
72e306c
min should be PYTHON3_VERSION
ikonst Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mypy/test/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import pytest

from mypy import defaults
from mypy.test.config import PREFIX, test_data_prefix, test_temp_dir

root_dir = os.path.normpath(PREFIX)
Expand Down Expand Up @@ -166,6 +167,10 @@ def _item_fail(msg: str) -> NoReturn:
version = tuple(int(x) for x in version_str.split("."))
except ValueError:
_item_fail(f"{version_str!r} is not a valid python version")
if version < defaults.PYTHON3_VERSION_MIN:
Comment thread
ikonst marked this conversation as resolved.
Outdated
_item_fail(
f"Version check against {version}; must be >= {defaults.PYTHON3_VERSION_MIN}"
)
if compare_op == ">=":
version_check = sys.version_info >= version
elif compare_op == "==":
Expand Down
⚡