Remove confusing instance variable example in cheat sheet#15441
Merged
hauntsaninja merged 1 commit intopython:masterfrom Jun 15, 2023
Merged
Remove confusing instance variable example in cheat sheet#15441hauntsaninja merged 1 commit intopython:masterfrom
hauntsaninja merged 1 commit intopython:masterfrom
Conversation
Contributor
|
LGTM. I don't see any value in that example, and agree it's a dubious practice especially when people then carry it into mutable types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mypy cheat sheet documentation provides an example on how to type instance and class attributes. However, it shows that an attribute with a default value in the class body is an instance variable, and I don't think this is correct. I understand that strings are immutable, which makes the example valid in the end, but I don't believe this is a great practice to define instance variables with a value outside of the init method.
Please let me know if you disagree or would prefer to change the comment rather than deleting the example.