stubgen: multiple fixes to the generated imports#15624
Merged
hauntsaninja merged 3 commits intopython:masterfrom Sep 25, 2023
Merged
stubgen: multiple fixes to the generated imports#15624hauntsaninja merged 3 commits intopython:masterfrom
hauntsaninja merged 3 commits intopython:masterfrom
Conversation
* Fix handling of nested imports Instead of assuming that a name is imported from a top level package, look in the imports for this name starting from the parent submodule up until the import is found * Fix "from imports" getting rexported unnecessarily * Fix import sorting when having import aliases Fixes python#13661 Fixes python#7006
Collaborator
Author
|
Please note that this has been tested with a mypy_primer-like script that I wrote locally for stubgen. The script was run on a bunch of packages from the scientific suite (matplotlib, numpy, pandas, seaborn, scipy). I inspected all the changes in the output one by one and they were all correct. It removed a bunch of unnecessary re-exports and added a single missing nested import in matplotlib. So overall I am confident with this change. |
hauntsaninja
approved these changes
Sep 25, 2023
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
(not the most familiar with stubgen but) this looks great, thanks! And awesome to hear about your stubgen primer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of assuming that a name is imported from a top level package, look in the imports for this name starting from the parent submodule up until the import is found
Fixes #13661
Fixes #7006