Bump PYTHON3_VERSION_MIN to 3.7#15668
Merged
hauntsaninja merged 7 commits intomasterfrom Jul 15, 2023
Merged
Conversation
AlexWaygood
reviewed
Jul 14, 2023
AlexWaygood
reviewed
Jul 14, 2023
AlexWaygood
reviewed
Jul 14, 2023
AlexWaygood
reviewed
Jul 14, 2023
AlexWaygood
reviewed
Jul 14, 2023
AlexWaygood
reviewed
Jul 14, 2023
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Thanks for the quick review, addressed! |
This comment has been minimized.
This comment has been minimized.
AlexWaygood
approved these changes
Jul 14, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM! One failing test left to resolve 🚀
This comment has been minimized.
This comment has been minimized.
cdce8p
reviewed
Jul 14, 2023
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pybind11 (https://github.com/pybind/pybind11): typechecking got 8.25x slower (1.8s -> 15.1s)
(Performance measurements are based on a single noisy sample)
+ pyproject.toml: [mypy]: python_version: Python 3.6 is not supported (must be 3.7 or higher)
+ setup.py:99: error: Class cannot subclass "sdist" (has type "Any") [misc]
- /tmp/mypy_primer/projects/_pybind11_venv/lib/python3.10/site-packages/markdown_it/common/utils.py:106: error: Assignment expressions are only supported in Python 3.8 and greater [syntax]
+ pybind11/setup_helpers.py:69: error: Unused "type: ignore" comment [unused-ignore]
+ pybind11/setup_helpers.py:70: error: Unused "type: ignore" comment [unused-ignore]
+ pybind11/setup_helpers.py:87: error: Class cannot subclass "_Extension" (has type "Any") [misc]
+ pybind11/setup_helpers.py:269: error: Class cannot subclass "_build_ext" (has type "Any") [misc]
|
hauntsaninja
approved these changes
Jul 15, 2023
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Nice cleanup, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15665