Skip to content

Allow None vs TypeVar overlap for overloads #15846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 6 commits into from
Aug 14, 2023
Merged

Allow None vs TypeVar overlap for overloads #15846

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11c082e
Allow None vs TypeVar overlap for overloads
Aug 10, 2023
494016a
Fix typo
Aug 10, 2023
05eb6ff
Add heuristic to enforce union math for None vs TypeVar overlap
Aug 11, 2023
f4e78ea
Awoid spurious errors
Aug 11, 2023
123fea4
Update mypy/checkexpr.py
ilevkivskyi Aug 11, 2023
76ec63f
Fix crash on non-matching overload
Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2503,7 +2503,8 @@ def check_overload_call(
callable_name=callable_name,
object_type=object_type,
)
if union_interrupted:
# Do not show the extra error is the union math was forced.
Comment thread
ilevkivskyi marked this conversation as resolved.
Outdated
if union_interrupted and not none_type_var_overlap:
self.chk.fail(message_registry.TOO_MANY_UNION_COMBINATIONS, context)
return result

Expand Down
⚡