Fix assert_type failures when some nodes are deferred#15920
Merged
Conversation
AlexWaygood
approved these changes
Aug 21, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
This LGTM! One minor suggestion to make the variable names in the test make a little more sense:
AlexWaygood
approved these changes
Aug 21, 2023
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: spack (https://github.com/spack/spack): typechecking got 1.29x slower (52.6s -> 67.7s)
(Performance measurements are based on a single noisy sample)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it is quite the same as
reveal_type. Which is defined here:mypy/mypy/checkexpr.py
Line 4297 in 2c1fd97
Closes #15851