Skip to content

Fix crash when parsing error code config with typo #16005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 3 commits into from
Sep 1, 2023
Merged

Fix crash when parsing error code config with typo #16005

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f49da0
Fix crash when parsing error code config with typo
hauntsaninja Aug 31, 2023
af92312
suggest
hauntsaninja Sep 1, 2023
c69ec14
nit
hauntsaninja Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions mypy/config_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,19 @@ def parse_section(
options_key = key
if key in config_types:
ct = config_types[key]
elif key in ("enabled_error_codes", "disabled_error_codes"):
# These should be "enable_error_code" and "disable_error_code". But because these fields
# exist on Options, we would otherwise accept them here and crash later.
suggestion = {
"enabled_error_codes": "enable_error_code",
"disabled_error_codes": "disable_error_code",
}
Copy link
Copy Markdown

@cebtenzzre cebtenzzre Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move the dict outside of the loop and check against e.g. key in option_replacements to avoid the repetition?

print(
f"{prefix}Unrecognized option: {key} = {section[key]}"
f" (did you mean {suggestion[key]}?)",
file=stderr,
)
continue
else:
dv = None
# We have to keep new_semantic_analyzer in Options
Expand Down
⚡