Document and rename overload-overlap error code by hauntsaninja · Pull Request #16074 · python/mypy

hauntsaninja · 2023-09-09T06:36:23Z

A new error code was introduced in
#16061

As per #16068, we didn't previously run doc builds on changes to errorcodes.py, causing tests to fail on master when this was merged.

Renaming the code as per:
#16061 (comment) All type ignores should be unsafe, so we should save the unsafe adjective for things that are really unsafe. As it stands, there are many cases where overloads overlap somewhat benignly.

Fixes #8656

A new error code was introduced in python#16061 As per python#16068, we didn't previously run doc builds on changes to errorcodes.py, causing tests to fail on master when this was merged. Renaming the code as per: python#16061 (comment) All type ignores should be unsafe, so we should save the unsafe adjective for things that are really unsafe. As it stands, there are many cases where overloads overlap somewhat benignly.

AlexWaygood

Looks good, thanks! A few small comments:

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

github-actions · 2023-09-10T06:30:45Z

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas (https://github.com/pandas-dev/pandas)
- pandas/core/base.py:1318: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas/core/base.py:1318: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]

steam.py (https://github.com/Gobot1234/steam.py)
- steam/ext/commands/commands.py:929: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ steam/ext/commands/commands.py:929: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]

mypy (https://github.com/python/mypy)
+ mypy/types.py:3022: error: Unused "type: ignore" comment  [unused-ignore]
+ mypy/types.py:3022: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]
+ mypy/types.py:3022: note: Error code "overload-overlap" not covered by "type: ignore" comment
+ mypy/types.py:3022: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-overload-overlap for more info

aioredis (https://github.com/aio-libs/aioredis)
- aioredis/utils.py:45: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ aioredis/utils.py:45: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
- pandas-stubs/core/strings.pyi:44: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/strings.pyi:44: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:162: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:162: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:177: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:177: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:222: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:222: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:235: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:235: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:245: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:245: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:255: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:255: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:268: error: Overloaded function signatures 5 and 7 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:268: error: Overloaded function signatures 5 and 7 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:540: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:540: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:540: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:540: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:540: error: Overloaded function signatures 1 and 4 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:540: error: Overloaded function signatures 1 and 4 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:540: error: Overloaded function signatures 1 and 6 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:540: error: Overloaded function signatures 1 and 6 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:553: error: Overloaded function signatures 2 and 6 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:553: error: Overloaded function signatures 2 and 6 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:566: error: Overloaded function signatures 3 and 6 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:566: error: Overloaded function signatures 3 and 6 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:579: error: Overloaded function signatures 4 and 6 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:579: error: Overloaded function signatures 4 and 6 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:645: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:645: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:671: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:671: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:704: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:704: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:840: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:840: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:848: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:848: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:865: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:865: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:881: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:881: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1175: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:1175: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:1182: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1182: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1182: error: Overloaded function signatures 2 and 4 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1182: error: Overloaded function signatures 2 and 4 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1182: error: Overloaded function signatures 2 and 5 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1182: error: Overloaded function signatures 2 and 5 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1182: error: Overloaded function signatures 2 and 6 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1182: error: Overloaded function signatures 2 and 6 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1189: error: Overloaded function signatures 3 and 4 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1189: error: Overloaded function signatures 3 and 4 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1189: error: Overloaded function signatures 3 and 5 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1189: error: Overloaded function signatures 3 and 5 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1189: error: Overloaded function signatures 3 and 6 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1189: error: Overloaded function signatures 3 and 6 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1196: error: Overloaded function signatures 4 and 5 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1196: error: Overloaded function signatures 4 and 5 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1196: error: Overloaded function signatures 4 and 6 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1196: error: Overloaded function signatures 4 and 6 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1203: error: Overloaded function signatures 5 and 6 overlap with incompatible return types  [unsafe-overload]
+ pandas-stubs/core/series.pyi:1203: error: Overloaded function signatures 5 and 6 overlap with incompatible return types  [overload-overlap]
- pandas-stubs/core/series.pyi:1466: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ pandas-stubs/core/series.pyi:1466: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- pandas-stubs/core/series.pyi:1498: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]

... (truncated 429 lines) ...

operator (https://github.com/canonical/operator)
- ops/pebble.py:2163: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ ops/pebble.py:2163: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]
- ops/model.py:2455: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ ops/model.py:2455: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]

pytest (https://github.com/pytest-dev/pytest)
- src/_pytest/mark/structures.py:344: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ src/_pytest/mark/structures.py:344: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]

jax (https://github.com/google/jax)
- jax/_src/numpy/lax_numpy.py:1062: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ jax/_src/numpy/lax_numpy.py:1062: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]

hydra-zen (https://github.com/mit-ll-responsible-ai/hydra-zen)
- src/hydra_zen/typing/_builds_overloads.py:44: error: Overloaded function signatures 1 and 4 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:44: error: Overloaded function signatures 1 and 4 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:44: error: Overloaded function signatures 1 and 5 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:44: error: Overloaded function signatures 1 and 5 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:44: error: Overloaded function signatures 1 and 6 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:44: error: Overloaded function signatures 1 and 6 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:65: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:65: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:65: error: Overloaded function signatures 2 and 5 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:65: error: Overloaded function signatures 2 and 5 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:65: error: Overloaded function signatures 2 and 6 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:65: error: Overloaded function signatures 2 and 6 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:86: error: Overloaded function signatures 3 and 5 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:86: error: Overloaded function signatures 3 and 5 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:86: error: Overloaded function signatures 3 and 6 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:86: error: Overloaded function signatures 3 and 6 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:107: error: Overloaded function signatures 4 and 5 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:107: error: Overloaded function signatures 4 and 5 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:107: error: Overloaded function signatures 4 and 6 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:107: error: Overloaded function signatures 4 and 6 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:129: error: Overloaded function signatures 5 and 8 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:129: error: Overloaded function signatures 5 and 8 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:129: error: Overloaded function signatures 5 and 9 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:129: error: Overloaded function signatures 5 and 9 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:150: error: Overloaded function signatures 6 and 7 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:150: error: Overloaded function signatures 6 and 7 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:150: error: Overloaded function signatures 6 and 9 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:150: error: Overloaded function signatures 6 and 9 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:172: error: Overloaded function signatures 7 and 9 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:172: error: Overloaded function signatures 7 and 9 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:193: error: Overloaded function signatures 8 and 9 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:193: error: Overloaded function signatures 8 and 9 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:270: error: Overloaded function signatures 1 and 5 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:270: error: Overloaded function signatures 1 and 5 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:270: error: Overloaded function signatures 1 and 6 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:270: error: Overloaded function signatures 1 and 6 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:270: error: Overloaded function signatures 1 and 7 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:270: error: Overloaded function signatures 1 and 7 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:290: error: Overloaded function signatures 2 and 6 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:290: error: Overloaded function signatures 2 and 6 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:290: error: Overloaded function signatures 2 and 7 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:290: error: Overloaded function signatures 2 and 7 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:310: error: Overloaded function signatures 3 and 4 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:310: error: Overloaded function signatures 3 and 4 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:310: error: Overloaded function signatures 3 and 6 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:310: error: Overloaded function signatures 3 and 6 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:310: error: Overloaded function signatures 3 and 7 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:310: error: Overloaded function signatures 3 and 7 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:330: error: Overloaded function signatures 4 and 6 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:330: error: Overloaded function signatures 4 and 6 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:330: error: Overloaded function signatures 4 and 7 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:330: error: Overloaded function signatures 4 and 7 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:351: error: Overloaded function signatures 5 and 6 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:351: error: Overloaded function signatures 5 and 6 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:351: error: Overloaded function signatures 5 and 7 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:351: error: Overloaded function signatures 5 and 7 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:373: error: Overloaded function signatures 6 and 9 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:373: error: Overloaded function signatures 6 and 9 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:373: error: Overloaded function signatures 6 and 10 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:373: error: Overloaded function signatures 6 and 10 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:394: error: Overloaded function signatures 7 and 8 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:394: error: Overloaded function signatures 7 and 8 overlap with incompatible return types  [overload-overlap]
- src/hydra_zen/typing/_builds_overloads.py:394: error: Overloaded function signatures 7 and 10 overlap with incompatible return types  [unsafe-overload]
+ src/hydra_zen/typing/_builds_overloads.py:394: error: Overloaded function signatures 7 and 10 overlap with incompatible return types  [overload-overlap]

... (truncated 46 lines) ...

scrapy (https://github.com/scrapy/scrapy)
- scrapy/utils/spider.py:37: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ scrapy/utils/spider.py:37: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]

discord.py (https://github.com/Rapptz/discord.py)
- discord/state.py:1191: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ discord/state.py:1191: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:291: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:291: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:295: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:295: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:1351: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:1351: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:1355: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:1355: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:1678: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:1678: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:1682: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:1682: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:1859: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:1859: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:1863: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:1863: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:2378: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:2378: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [overload-overlap]
- discord/channel.py:2382: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [unsafe-overload]
+ discord/channel.py:2382: error: Overloaded function signatures 2 and 3 overlap with incompatible return types  [overload-overlap]
- discord/app_commands/tree.py:577: error: Overloaded function signatures 1 and 4 overlap with incompatible return types  [unsafe-overload]
+ discord/app_commands/tree.py:577: error: Overloaded function signatures 1 and 4 overlap with incompatible return types  [overload-overlap]
- discord/app_commands/tree.py:586: error: Overloaded function signatures 2 and 4 overlap with incompatible return types  [unsafe-overload]
+ discord/app_commands/tree.py:586: error: Overloaded function signatures 2 and 4 overlap with incompatible return types  [overload-overlap]
- discord/app_commands/tree.py:595: error: Overloaded function signatures 3 and 4 overlap with incompatible return types  [unsafe-overload]
+ discord/app_commands/tree.py:595: error: Overloaded function signatures 3 and 4 overlap with incompatible return types  [overload-overlap]
- discord/ext/commands/core.py:1729: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ discord/ext/commands/core.py:1729: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]
- discord/ext/commands/core.py:1799: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [unsafe-overload]
+ discord/ext/commands/core.py:1799: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [overload-overlap]

streamlit (https://github.com/streamlit/streamlit)
- lib/streamlit/elements/widgets/multiselect.py:64: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ lib/streamlit/elements/widgets/multiselect.py:64: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- lib/streamlit/delta_generator.py:430: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ lib/streamlit/delta_generator.py:430: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- lib/streamlit/delta_generator.py:978: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ lib/streamlit/delta_generator.py:978: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]

bokeh (https://github.com/bokeh/bokeh)
- src/bokeh/embed/standalone.py:137: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ src/bokeh/embed/standalone.py:137: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- src/bokeh/embed/standalone.py:144: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ src/bokeh/embed/standalone.py:144: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]
- src/bokeh/embed/standalone.py:151: error: Unused "type: ignore" comment, use narrower [unsafe-overload] instead of [misc] code  [unused-ignore]
+ src/bokeh/embed/standalone.py:151: error: Unused "type: ignore" comment, use narrower [overload-overlap] instead of [misc] code  [unused-ignore]

hauntsaninja changed the title ~~Document and rename overlap-overload error code~~ Document and rename overload-overlap error code Sep 9, 2023

hauntsaninja requested review from AlexWaygood and JelleZijlstra September 9, 2023 06:40

more detail

aac97d0

hauntsaninja force-pushed the broken-tests branch from 83eaf66 to aac97d0 Compare September 9, 2023 06:55

This comment has been minimized.

Sign in to view

AlexWaygood reviewed Sep 9, 2023

View reviewed changes

Comment thread docs/source/error_code_list.rst Outdated

Comment thread docs/source/error_code_list.rst Outdated

Comment thread docs/source/more_types.rst Outdated

Apply suggestions from code review

0709305

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

hauntsaninja merged commit ed18fea into python:master Sep 10, 2023

hauntsaninja deleted the broken-tests branch September 10, 2023 06:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Document and rename overload-overlap error code#16074

Document and rename overload-overlap error code#16074
hauntsaninja merged 3 commits intopython:masterfrom
hauntsaninja:broken-tests

hauntsaninja commented Sep 9, 2023 •

edited

Loading

Uh oh!

This comment has been minimized.

AlexWaygood left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hauntsaninja commented Sep 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hauntsaninja commented Sep 9, 2023 •

edited

Loading