Correctly handle runtime type applications of variadic types#16240
Merged
ilevkivskyi merged 2 commits intopython:masterfrom Oct 15, 2023
Merged
Correctly handle runtime type applications of variadic types#16240ilevkivskyi merged 2 commits intopython:masterfrom
ilevkivskyi merged 2 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
This (and other 3 PRs on variadic types) are open for a week now. I will start merging them without review, one per day, starting from the most trivial one. |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some missing pieces to runtime type application handling for both
TypeVarTupleandParamSpec. Everything is straightforward (maybe a bit hacky, but we already importtypeanalincheckexprfor similar purposes, e.g. type aliases in runtime context).Fixes #14799