[mypyc] Optimize TYPE_CHECKING to False at Runtime#16263
Merged
JukkaL merged 3 commits intopython:masterfrom Feb 28, 2024
Merged
[mypyc] Optimize TYPE_CHECKING to False at Runtime#16263JukkaL merged 3 commits intopython:masterfrom
JukkaL merged 3 commits intopython:masterfrom
Conversation
Contributor
Author
|
@JukkaL Is there a way I can request a review? |
Contributor
Author
|
@JukkaL ? |
JukkaL
approved these changes
Feb 28, 2024
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR, and sorry about the slow review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#902
This PR finds references of
typing.TYPE_CHECKINGortyping_extensions.TYPE_CHECKINGand optimizes them toFalsein mypyc.