[mypyc] Don't crash on unreachable statements#16311
Merged
Conversation
Skip them instead. This applies to statements after break, continue, return and raise statements. It's common to have unreachable statements temporarily while working on a half-finish change, so generating an error is perhaps not the best option. Fixes mypyc/mypyc#1028.
msullivan
approved these changes
Oct 21, 2023
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
Nice fix to an old problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip them instead. This applies to statements after break, continue, return and raise statements.
It's common to have unreachable statements temporarily while working on a half-finished change, so generating an error is perhaps not the best option.
Fixes mypyc/mypyc#1028.