Skip to content

[mypyc] Remangle redefined names produced by async with#16408

Merged
JukkaL merged 2 commits intopython:masterfrom
ichard26:fix-async-with-var-reuse
Feb 28, 2024
Merged

[mypyc] Remangle redefined names produced by async with#16408
JukkaL merged 2 commits intopython:masterfrom
ichard26:fix-async-with-var-reuse

Conversation

@ichard26
Copy link
Copy Markdown
Collaborator

@ichard26 ichard26 commented Nov 5, 2023

JelleZijlstra
JelleZijlstra reviewed Nov 5, 2023
View reviewed changes
Comment thread mypyc/test-data/run-async.test
JelleZijlstra
JelleZijlstra reviewed Nov 5, 2023
View reviewed changes
Comment thread mypyc/test-data/run-async.test Outdated
@ichard26 @JelleZijlstra
Apply suggestions from code review
50eabf5 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@ichard26
Copy link
Copy Markdown
Collaborator Author

ichard26 commented Nov 15, 2023 

___________________________ mypy/test/testdaemon.py ___________________________
[gw0] win32 -- Python 3.8.10 D:\a\mypy\mypy\.tox\py38\Scripts\python.EXE
worker 'gw0' crashed while running 'mypy/test/testdaemon.py::DaemonSuite::daemon.test::testDaemonRun'

I love CI right now.

@ichard26 ichard26 closed this Nov 15, 2023
@ichard26 ichard26 reopened this Nov 15, 2023
JukkaL
JukkaL approved these changes Feb 28, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the slow review.

@JukkaL JukkaL merged commit 162c74d into python:master Feb 28, 2024
@ichard26 ichard26 deleted the fix-async-with-var-reuse branch February 28, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error when reusing variable name in async context manager

3 participants

@ichard26 @JelleZijlstra @JukkaL
⚡