Handle TypeVarTupleType when checking overload constraints#16428
Merged
ilevkivskyi merged 3 commits intopython:masterfrom Nov 10, 2023
Merged
Handle TypeVarTupleType when checking overload constraints#16428ilevkivskyi merged 3 commits intopython:masterfrom
ilevkivskyi merged 3 commits intopython:masterfrom
Conversation
robjhornby
changed the title
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Nov 10, 2023
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR.
I have some minor suggestions that I am going to apply now.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: spack (https://github.com/spack/spack): typechecking got 1.26x slower (56.1s -> 70.7s)
(Performance measurements are based on a single noisy sample)
|
Contributor
Author
|
Thanks for the quick turnaround, looking forward to the new typevar tuple features being released! |
JukkaL
pushed a commit
that referenced
this pull request
Nov 10, 2023
Fixes #16427 The test case added in the first commit crashes. The second commit addresses the crash - I don't know whether this fix is correct, it just happens to stop the crash but it leads to a code branch which just `continue`s out of a for loop iteration, so it might be bypassing something it shouldn't. I don't completely understand it. --------- Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16427
The test case added in the first commit crashes.
The second commit addresses the crash - I don't know whether this fix is
correct, it just happens to stop the crash but it leads to a code branch
which just
continues out of a for loop iteration, so it might bebypassing something it shouldn't. I don't completely understand it.