Fix handling of tuple type context with unpacks#16444
Merged
ilevkivskyi merged 3 commits intopython:masterfrom Nov 10, 2023
Merged
Fix handling of tuple type context with unpacks#16444ilevkivskyi merged 3 commits intopython:masterfrom
ilevkivskyi merged 3 commits intopython:masterfrom
Conversation
JukkaL
approved these changes
Nov 10, 2023
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks, LGTM (assuming tests pass).
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The test failure look real. I guess the test case needs to skipped on older Python versions. |
Member
Author
Oh, I wrote the test using repro in the issue. I totally forgot I need to use backwards-compatible syntax (crash affects all Python versions). |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: anyio (https://github.com/agronholm/anyio): typechecking got 3.28x faster (16.8s -> 5.1s)
(Performance measurements are based on a single noisy sample)
|
ilevkivskyi
changed the title
JukkaL
pushed a commit
that referenced
this pull request
Nov 10, 2023
Fixes #16425 Fix is straightforward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16425
Fix is straightforward.