Support TypedDict functional syntax as class base type#16703
Merged
hauntsaninja merged 2 commits intopython:masterfrom Jan 14, 2024
Merged
Support TypedDict functional syntax as class base type#16703hauntsaninja merged 2 commits intopython:masterfrom
hauntsaninja merged 2 commits intopython:masterfrom
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
- steam/types/app.py:171: error: Unsupported dynamic base class "TypedDict" [misc]
- steam/types/app.py:173: error: NotRequired[] can be only used in a TypedDict definition [valid-type]
- steam/types/app.py:177: error: NotRequired[] can be only used in a TypedDict definition [valid-type]
- steam/types/app.py:178: error: NotRequired[] can be only used in a TypedDict definition [valid-type]
|
Contributor
Author
|
Sorry for the direct mention, but bumping @JukkaL / @hauntsaninja |
hauntsaninja
approved these changes
Jan 14, 2024
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks! Looks like pyright supports this syntax as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16701
This PR allows
TypedDict(...)calls to be used as a base class. This fixes the error emitted by mypy described in #16701 .