Skip to content

Update mypy daemon documentation note about local partial types#16782

Merged
hauntsaninja merged 3 commits intopython:masterfrom
MakonnenMak:patch-1
Jan 14, 2024
Merged

Update mypy daemon documentation note about local partial types#16782
hauntsaninja merged 3 commits intopython:masterfrom
MakonnenMak:patch-1

Conversation

@MakonnenMak
Copy link
Copy Markdown
Contributor

The existing documentation almost makes it seem like the user has the option to toggle this.

Updated wording to say strictly denoting it's not configurable with explanation from the code here

mypy/mypy/dmypy_server.py

Lines 196 to 198 in fbb738a

# Fine-grained incremental doesn't support general partial types
# (details in https://github.com/python/mypy/issues/4492)
options.local_partial_types = True
.

(Explain how this PR changes mypy.)

MakonnenMak and others added 2 commits January 13, 2024 21:05
The existing documentation almost makes it seem like the user has the option to toggle this. 

Updated wording to say strictly denoting it's not configurable with explanation from the code here https://github.com/python/mypy/blob/fbb738a4626976f83a7412df73533d87483a31b7/mypy/dmypy_server.py#L198.
Comment thread docs/source/mypy_daemon.rst Outdated
Copy link
Copy Markdown
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja merged commit 186ace3 into python:master Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants