Skip to content

Allow TypedDict initialization from Type#16963

Merged
hauntsaninja merged 1 commit intopython:masterfrom
cdce8p:fix-typeddict-init-from-type
Mar 1, 2024
Merged

Allow TypedDict initialization from Type#16963
hauntsaninja merged 1 commit intopython:masterfrom
cdce8p:fix-typeddict-init-from-type

Conversation

@cdce8p
Copy link
Copy Markdown
Collaborator

@cdce8p cdce8p commented Feb 29, 2024

Fixes #11644

@github-actions
Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Copy Markdown
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@hauntsaninja hauntsaninja merged commit 3c87af2 into python:master Mar 1, 2024
@cdce8p cdce8p deleted the fix-typeddict-init-from-type branch March 1, 2024 08:26
JelleZijlstra pushed a commit that referenced this pull request Mar 27, 2024
Followup to #16963
Correctly set optional and required keys for the TypedDict init
callable.

Ref: #11644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems passing around TypedDict and using it in Union.

2 participants