Add TypeGuard and TypeIs traversing in TypeTraverserVisitor (fixes #17029)#17071
Merged
hauntsaninja merged 2 commits intopython:masterfrom Mar 29, 2024
Merged
Add TypeGuard and TypeIs traversing in TypeTraverserVisitor (fixes #17029)#17071hauntsaninja merged 2 commits intopython:masterfrom
hauntsaninja merged 2 commits intopython:masterfrom
Conversation
cdce8p
reviewed
Mar 28, 2024
Comment on lines
+89
to
+90
| if t.type_guard is not None: | ||
| t.type_guard.accept(self) |
Collaborator
There was a problem hiding this comment.
Is this an issue for TypeIs as well? Probably as easy as adding an if t.type_is is not None clause here.
Member
There was a problem hiding this comment.
Yes, please add an analogous test for TypeIs as well. It should behave exactly the same here.
Contributor
Author
There was a problem hiding this comment.
Done, thanks! It was interesting to learn about TypeIs :)
This comment has been minimized.
This comment has been minimized.
sloboegen
changed the title
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17029.